Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add check for min height of evidence (backport #2007) #2008

Merged
merged 5 commits into from
Jul 3, 2024
Merged

fix!: add check for min height of evidence (backport #2007) #2008

merged 5 commits into from
Jul 3, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jul 3, 2024 •
edited
Loading

backport #2007.

@sainoe sainoe requested a review from a team as a code owner July 3, 2024 14:48
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sainoe sainoe changed the title fix!: add check for min height of evidence fix!: add check for min height of evidence (#2007) Jul 3, 2024
@sainoe sainoe changed the title fix!: add check for min height of evidence (#2007) fix!: add check for min height of evidence (backport #2007) Jul 3, 2024
@sainoe sainoe marked this pull request as draft July 3, 2024 14:55
@sainoe sainoe closed this Jul 3, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Jul 3, 2024
@sainoe sainoe reopened this Jul 3, 2024
@sainoe sainoe marked this pull request as ready for review July 3, 2024 15:19
@sainoe sainoe merged commit 6e7513a into release/v4.2.x-lsm Jul 3, 2024
22 of 31 checks passed
@sainoe sainoe deleted the sainoe/min-evidence-fix-4 branch July 3, 2024 15:33
sainoe added a commit that referenced this pull request Jul 4, 2024
@sainoe @insumity
fix!: add check for min height of evidence (backport #2007) (#2008)
24c9b84 
* init commit

* added check, setting, and deleting of the equivocation min height

* update changelog entry

* remove unwwanted changelog entry

* update changelog entries

---------

Co-authored-by: insumity <[email protected]>
sainoe added a commit that referenced this pull request Jul 4, 2024
@sainoe @insumity
fix!: add check for the height of evidence (backport #2007) (#2017)
350ef9f 
* chore!: prepare changelog for v4.2.1 release

* update changelog

* revert changelog v4.2.0 removal

* fix changes

* update changelog

* clean unreleased folder

* fix!: add check for min height of evidence (backport #2007) (#2008)

* init commit

* added check, setting, and deleting of the equivocation min height

* update changelog entry

* remove unwwanted changelog entry

* update changelog entries

---------

Co-authored-by: insumity <[email protected]>

---------

Co-authored-by: insumity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

Assignees
No one assigned
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sainoe @mpoke @insumity